search

openhab / openhab-js

openHAB JavaScript Library for JavaScript Scripting Automation
https://www.openhab.org/addons/automation/jsscripting/
Eclipse Public License 2.0
38 stars 31 forks source link

Fix silent failure of `ItemHistory.historicState` #248

Closed rkoshak closed 1 year ago

rkoshak commented 1 year ago

Fixes #246

rkoshak commented 1 year ago

I don't know why the DCO is failing all of a sudden. I added the "signed-off-by" to both of these new commits. At least now the linting problems are gone. I'm not sure how they got added. The only thing I can think is VSCode is enforcing a code. I need to figure how to turn that off.

florian-h05 commented 1 year ago

You have a typo in your first sign off, but I can force DCO to pass, so no problem. I will take care of the type defs and the CHANGELOG.