search

openhab / openhab-js

openHAB JavaScript Library for JavaScript Scripting Automation
https://www.openhab.org/addons/automation/jsscripting/
Eclipse Public License 2.0
38 stars 31 forks source link

Typos a/an #277

Closed dilyanpalauzov closed 12 months ago

florian-h05 commented 12 months ago

And please sign off your commits, otherwise I cannot merge them. https://github.com/openhab/openhab-js/pull/277/checks?check_run_id=14820783373 gives advice how to sign off your existing commits, or just comment your sign off here.

dilyanpalauzov commented 12 months ago

I am not going to add a sign-off line, since in my eyes this has no added value.

florian-h05 commented 12 months ago

I have checked your other a/an typos, seems like they applied the exception, so I will make the same exception here.

Note that it does not matter for any one whether the sign off has an added value or not, it is a rule several open-source projects have and openHAB has as well: https://www.openhab.org/docs/developer/contributing.html#sign-your-work.