search

openhab / openhab-js

openHAB JavaScript Library for JavaScript Scripting Automation
https://www.openhab.org/addons/automation/jsscripting/
Eclipse Public License 2.0
38 stars 31 forks source link

README: Add JS-Joda locale installation and usage #322

Closed rkoshak closed 4 months ago

rkoshak commented 4 months ago

Closes #54.

Adds a section that explains when one might need to install a JS-Joda locale, why, and how to install a locale, import and use it in a rule.

rkoshak commented 4 months ago

Somehow I think I ended up making this PR to my own fork and not here where it belongs. Trying again since I see no evidence that my PR exists anywhere but on my own fork.

florian-h05 commented 4 months ago

This PR is a the correct place. Can you please fix the markdown lint?

rkoshak commented 4 months ago

I think I messed up the DCO on the markdown linting fix. It was just inserting a newline so hopefully I can squeak under and not have to redo it. The original commit was properly signed off.

florian-h05 commented 4 months ago

I’ll set DCO to pass.

florian-h05 commented 4 months ago

@rkoshak Thanks, looks good now! This finally fixes #54.