[actions] Add notification builder & Mark some actions deprecated as replaced by better APIs

openhab / openhab-js

openHAB JavaScript Library for JavaScript Scripting Automation

https://www.openhab.org/addons/automation/jsscripting/

Eclipse Public License 2.0

38 stars 31 forks source link

[actions] Add notification builder & Mark some actions deprecated as replaced by better APIs #351

Closed florian-h05 closed 2 days ago

florian-h05 commented 4 days ago

This adds builders to create broadcast, log and standard notifications and allow easy usage of the new functionality provided by https://github.com/openhab/openhab-addons/issues/16934 without having to deal with method param orders.

It also marks several actions as deprecated, because their functionality was replaced by better and often pure JS APIs.

florian-h05 commented 4 days ago

To Dos:

[x] Add JSDoc for onClickAction, actionButton1 etc. once action format docs have been released.
[x] Extend README for onClickAction, actionButton1 etc. once action format docs have been released.
[x] Regenerate type defs.

digitaldan commented 4 days ago

Awesome !

florian-h05 commented 3 days ago

@mueller-ma I have implemented your proposals, updated the unit tests, updates the README and added the missing JSDoc.

florian-h05 commented 3 days ago

@digitaldan Do you want to review or should I self-merge?

digitaldan commented 2 days ago

LGTM, thanks !!!!!!

florian-h05 commented 2 days ago

I will test this soon in production and then publish a new release and update the add-on.

florian-h05 commented 2 days ago

Works fine for me, however I can only test the message due to client limitations (iOS App). Would be great if you could give it a try once I published a new version.

digitaldan commented 2 days ago

Will try it today! I'm hoping to get a test flight build soon of the new IOS app.