Add clean functions to cli

openhab / openhab-linuxpkg

Repo for Linux packages

Eclipse Public License 2.0

18 stars 33 forks source link

Add clean functions to cli #105

Closed BClark09 closed 6 years ago

BClark09 commented 6 years ago

Added the commands:
- clean-cache - Cleans the openHAB temporary folders.
- reset-config - Reinstalls openHAB with default system configuration.
- reset-ownership - Resets the ownership of openHAB directories.
Alphabetised the order of the commands.

Signed-off-by: Ben Clark ben@benjyc.uk

BClark09 commented 6 years ago

Hey @ThomDietrich

I've added an initial "set ownership", do you think that setting the permissions would also be useful for the general cli? openHABian is chmod -R ug+wX for all folders is that correct?

ThomDietrich commented 6 years ago

After a quick review everything looks good I'd say. 👍 The command was primarily needed so that the group also has write permissions. In your scenario that is not needed. Thanks for including an overwrite option for openHABian.

ThomDietrich commented 6 years ago

One additional comment: I imagine some users will not know what these options do and when to use them. A few more lines of clarification would be good.

BClark09 commented 6 years ago

Cheers @ThomDietrich, I've made some adjustments which meant removing the reset-config command. I noticed that if the user is on snapshot, and these are cleaned from the repository then the reinstallation will fail, putting the installation in a broken state. Will have to think about that a bit more.