search

openhab / openhab-linuxpkg

Repo for Linux packages
Eclipse Public License 2.0
18 stars 33 forks source link

Add HTTP listen address setting to envvar list #111

Closed BClark09 closed 6 years ago

BClark09 commented 6 years ago

Related: https://github.com/openhab/openhab-docs/pull/638

Signed-off-by: Ben Clark ben@benjyc.uk

BClark09 commented 6 years ago

@ThomDietrich, I had a thought before merging this:

If the apt packages are set to automatically accept the maintainer version, then this will reset everyone's custom envars (EXTRA_JAVA_OPTS is the concern for me). I wonder if there's a way around it, like keeping a copy of /etc/default/openhab2 and replacing it after the update?

ThomDietrich commented 6 years ago

Hey @BClark09 hmmm well with

If the apt packages are set to automatically accept the maintainer version

I guess that is what one has to live with.

If we want to discuss the issue I feel we should rather discuss removing the setting/suggestion. After all the "What do you want to do?" question was invented by some wise Linux guy for a reason 😃

BClark09 commented 6 years ago

That sounds good to me! :) With https://github.com/openhab/openhab-distro/pull/647 and an accompanying csv style update file for specifics (like the logging file) there would be very little room for something to go wrong, so it should be safe to remove.