Add command to update repo sources in openhab-cli

openhab / openhab-linuxpkg

Repo for Linux packages

Eclipse Public License 2.0

18 stars 33 forks source link

Add command to update repo sources in openhab-cli #144

Closed BClark09 closed 4 years ago

BClark09 commented 5 years ago

Closes #136

Adds template rpm and apt source files as well so that users can easily switch repos.
Adds the repos current public key so that it can be easily updated in the future.

Signed-off-by: Ben Clark ben@benjyc.uk

BClark09 commented 5 years ago

Thoughts on this addition would be most welcome.

@openhab/openhabian-maintainers, just an FYI - this may be useful to call when calling openHABians update functions.

@kaikreuzer, I've added this function in preparation for two events:

We change the suggested testing repo to Artifactory, we can update Bintray with a final package that has an updated source template, and then users need only use the command openhab-cli update-repo testing (or we can do this for them).
The public key expires on 2019-07-25, ahead of this time we should probably update the public key. I have included a copy of it in this repo so that we can replace it if needed.

kaikreuzer commented 4 years ago

Just noticed that this is more than 1 year old by now... @BClark09 Are you still waiting for having it merged by a @openhab/linuxpkg-maintainers? As there are just 2, I guess you can decide to allow self-merging of PRs (at least after a few days), wdyt?

theoweiss commented 4 years ago

I'm in maintenance mode ;-) . @BClark09 is the master and should not wait for my lgtm.

BClark09 commented 4 years ago

As there are just 2, I guess you can decide to allow self-merging of PRs (at least after a few days), wdyt?

Sounds fair, but I think it would also make sense to request that for any PR that may affect openHABian that there should be a review from another person in @openhab/openhabian-maintainers. I'll request a review for next time.

As for the PR I think there's probably a better approach to this than what I submitted all that time ago so I'll close this for now in favour of submitting a different one.