search

openhab / openhab-linuxpkg

Repo for Linux packages
Eclipse Public License 2.0
18 stars 33 forks source link

Prepare initial openHAB 3.x packages #169

Closed BClark09 closed 4 years ago

BClark09 commented 4 years ago

openHAB 3.X's packages are lno longer installed into version specific */openhab2 directories but in */openhab instead.

There's no defined upgrade path yet for openHAB 3. For now, install it as a separate application, in which openHAB 2 has to be uninstalled first (user configuration files are kept).

Signed-off-by: Ben Clark ben@benjyc.uk

BClark09 commented 4 years ago

Hi @openhab/distro-maintainers, this PR allows openHAB 3.x snapshots to be distributed with APT and YUM. You need to explicitly install openhab (without the 2) to install it, and it will prompt an uninstall of openHAB 2.x first. Files will be installed in different directories as mentioned above.

I've tried to monitor the state of the core and distro, but if/when you think the builds are ready for some early testing, let me know and I can enable the packages in the snapshot repository.

cweitkamp commented 4 years ago

Sounds good. I really can't wait to use OH 3 snapshot in my test environment. But I would suggest to wait until https://github.com/openhab/openhab-core/pull/1451 is in the game. From my POV after migration of the DSL rule engine we have a quite nice first alpha version for testing.

kaikreuzer commented 4 years ago

Excellent, thanks for the preparations @BClark09!

I agree with @cweitkamp, we should soon be ready for early testing. I have been a bit slow on openhab/openhab-core#1451 in the past weeks, but I hope to finish it very soon!

cweitkamp commented 4 years ago

https://github.com/openhab/openhab-core/pull/1451 has been merged. We now can think about / continue on these changes.

BClark09 commented 4 years ago

The way that I've set this up so far is to make openHAB 2 and openHAB 3 incompatible. You'll have to uninstall OH2 to install OH3. APT does this for you, but YUM does not and will refuse to install.

I think while we're still in in an early testing/alpha stage this is probably where we should keep it for the time being. I can post instructions to those wanting to try it when this PR is merged.

The only change I need to make to this PR is to clear the environment variables on a new install of openHAB 3, they don't get set if the system isn't restarted after OH2 is removed..

BClark09 commented 4 years ago

Thanks @cweitkamp! I've responded to your comments and have fixed the export issue, I will give one more test on Debian and Fedora before merging.

BClark09 commented 4 years ago

All good to go, if we enable the openHAB 3 version of the openhab-linuxpkg job on Jenkins then we will start serving openhab snapshot packages.

kaikreuzer commented 3 years ago

@BClark09 Is it safe to enable the build plan now (I mean, will it have any impact on openHAB2 packages or will it peacefully co-exist to them)?

BClark09 commented 3 years ago

Not yet, just need to add a bit of of post installation script to copy files across from OH2 if it was installed. I've set aside some time for this so hope to be done on Tuesday.

The two packages can't be installed at the same time but enabling the OH3 package builds won't force people onto it, they will continue to get OH2 updates and can switch to OH3 at any time.

BClark09 commented 3 years ago

Hi @kaikreuzer, I've finished the basic changes but ideally I'd like a solution for the problems outlined in https://github.com/openhab/openhab-linuxpkg/pull/181#issuecomment-685122933 before I'd be happy enabling the builds.

kaikreuzer commented 3 years ago

181 is only relevant for people wanting to do/test a migration, right?

I'd think we should nonetheless enable to build already, so that people can at least start using it for test installations that are anyhow set up from scratch.