Closed BClark09 closed 7 years ago
https://github.com/openhab/openhab-linuxpkg/pull/18/files?w=1 Makes more sense to compare.
I've build and released this PR to my personal Bintray repo and tested an upgrade from openhab2-offline. It worked like a charm!! I think there are two issues we should address with subsequent PR's:
The kar file names should have the timestamp version numbers. Current names are:
/usr/share/openhab2/addons/openhab-addons-2.0.0-SNAPSHOT.kar
/usr/share/openhab2/addons/openhab-addons-legacy-2.0.0-SNAPSHOT.kar
but should be:
/usr/share/openhab2/addons/openhab-addons-2.0.0~20170109220843-1.kar
/usr/share/openhab2/addons/openhab-addons-legacy-22.0.0~20170109220843-1.kar
Thanks @theoweiss, I gave them fixed names so that the files overwrite themselves each time. There is a bug in Karaf which crashes openHAB as soon as the file in the folder is removed, so it wouldn't be safe to remove first.
Thanks @theoweiss and @BClark09 for working on this so eagerly! I have just announced the changes of the distro in the forum. Once you have the APT packages ready in the repo for the people to consume, please drop a note on that topic in the forum as I have mentioned that this change is not yet available in the apt-repo.
@BClark09 Karaf is a beast ;-)
In response to https://github.com/openhab/openhab-distro/pull/369
For users:
apt-get install openhab2
will automatically remove openhab2-online or openhab2-offline in the process.apt-get install openhab2-addons openhab2-addons-legacy
will also ask to install openhab2 if not already on.apt-get install openhab2 openhab2-addons
gives same functionality as the oldapt-get install openhab2-offline
.See https://bintray.com/benclark/apt-repo2/openhab2/2.0.0~20170109150239 for an example of what gradle will build.
Signed-off-by: Ben Clark ben@benjyc.uk