init.d updates, fix restart and stop kill pid not in pidfile #30

openhab / openhab-linuxpkg

Repo for Linux packages

Eclipse Public License 2.0

18 stars 33 forks source link

init.d updates, fix restart and stop kill pid not in pidfile #30 #31

Closed abedwardsw closed 7 years ago

abedwardsw commented 7 years ago

restart should wait for process to stop, otherwise it doesn't work
stop, if the pidfile is incorrect, then it should also check for the existing process and stop it
rework into functions so we can re-use logic for stop/start in the restart call

BClark09 commented 7 years ago

Hi @abedwardsw, many thanks for the PR! I've tested this on Ubuntu 14 and it works for me!

Please could you sign off your commit as per the contributing guide? You can also link this PR to the issue you created by saying in the description "closes #30" and "closes #28"

@theoweiss Do you have any code formatting comments?

abedwardsw commented 7 years ago

@BClark09 commit message updated, please have a look.

BClark09 commented 7 years ago

Perfect, thanks! I'm happy with it but I'll wait a bit for @theoweiss to agree and then we'll merge!

theoweiss commented 7 years ago

LGTM.

@BClark09 The code formatting has to be fixed in general. We have not yet defined a formatting, but should do.

@abedwardsw Could you - for now - intend your code additions with 2 blanks and add a line like this to your next commit message: Signed-off-by: Adam Edwards <_your@email.org_> (github: abedwardsw)

Thanks!

abedwardsw commented 7 years ago

@BClark09 @theoweiss new commit created (rebased). Should be good now according to the "standard.."

BClark09 commented 7 years ago

Many thanks @abedwardsw!