openhab / openhab-linuxpkg

Repo for Linux packages
Eclipse Public License 2.0
18 stars 33 forks source link

Added java recommends #61

Closed BClark09 closed 7 years ago

BClark09 commented 7 years ago

Signed-off-by: Ben Clark ben@benjyc.uk

closes #58

BClark09 commented 6 years ago

@ThomDietrich turns out (cc @kaikreuzer), it probably doesn't blend ;) There are way too many varations of Java to be able to automatically install one without thinking about manual installs. I think I should change this to suggests?

ThomDietrich commented 6 years ago

That's a shame, one would wish all these virtual packages and deb relations would allow for something like this to work but as we found out in #58, it's not as easy. Suggests is probably also okay. We are highlighting Java as the prerequisite in the documentation and with #72 we'll have a clear warning if no supported java runtime is available.

BClark09 commented 6 years ago

with #72 we'll have a clear warning if no supported java runtime is available.

Unfortunately only with appending && \bin\true to the echo line in setenv, which I assume we shouldn't really do?