search

openhab / openhab-linuxpkg

Repo for Linux packages
Eclipse Public License 2.0
18 stars 33 forks source link

Add GitHub eye candy #69

Closed ThomDietrich closed 7 years ago

ThomDietrich commented 7 years ago

😃

Signed-off-by: Thomas Dietrich thomas.dietrich@tu-ilmenau.de (github: ThomDietrich)

BClark09 commented 7 years ago

Hey @ThomDietrich! Syntax highlighting was left out of this file since there are only two types of line for a default file called by systemd: comments and assignments. Would it be misleading to imply you could have bash/shell script in this file? Alternatively, if this is just for Github, could we use. gitattributes?

If you think not, I'll merge the PR. ☺️

ThomDietrich commented 7 years ago

Hey @BClark09, I didn't think this would be an issue. After some consideration I agree that not modifying the actual file is overall better. Let me draft two more commits (I'm too lazy to power up my git client :yum: )

ThomDietrich commented 7 years ago

@BClark09 wdyt?

BClark09 commented 7 years ago

Awesome! Much appreciated @ThomDietrich, sorry for being picky! :smiley:

BClark09 commented 7 years ago

:see_no_evil: I thought these changes only took place in master, which is why I merged, but it looks like .gitattributes the file isn't working yet, furthermore the branch has been set to 100% shell. Having a look at why this may be.

The change looks good to me still, perhaps we need to wait for another indexing?

BClark09 commented 7 years ago

Turns out the file needs to be indexed before updating to the new syntax highlighting. This should be done eventually or if the file is updated:

What are your thoughts on using INI instead of Shell for the file:

https://github.com/BClark09/openhab-linuxpkg/blob/master/resources/etc/default/openhab2 https://github.com/BClark09/openhab-linuxpkg/blob/master/resources/systemd/openhab2.service

ThomDietrich commented 7 years ago

Yes I should have mentioned that. Takes a few minutes.

Ini looks indeed way better. I've checked a few settings in vim beforehand and ini didn't look good there. I should have checked on GitHub instead :see_no_evil:

Go for it ;) Thanks!

ThomDietrich commented 7 years ago

Ini is btw also what I'm using in openHABian and the indexing problem tricked me once before :smile:

BClark09 commented 7 years ago

haha, I should learn to be more patient! :laughing: Thanks again!