openhab / openhab-linuxpkg

Repo for Linux packages
Eclipse Public License 2.0
18 stars 33 forks source link

Set /etc/default/openhab2 as a conffile. #7

Closed BClark09 closed 7 years ago

BClark09 commented 7 years ago

As it is in the the openhab-distro repo otherwise we'd be overwriting custom parameters.

Signed-off-by: Ben Clark ben@benjyc.uk

ThomDietrich commented 7 years ago

Thank you ;)

BClark09 commented 7 years ago

@theoweiss Am I okay to merge?

ThomDietrich commented 7 years ago

You are a maintainer of this repository. Therefore I'm preeetty sure you've already earned the right to do so with changes you are confident in ;)

BClark09 commented 7 years ago

:laughing: Thanks! It's new me so I'm just being cautious! Perhaps a little too much in this case. Let's go!

theoweiss commented 7 years ago

I'm perfectly fine with that merge. Thanks @BClark09 .

In case of an open discussion between maintainers or an other lack of clarity we should use the LGTM comment to signal the OK and get the maintainer majority before merging. https://github.com/openhab/openhab2-addons/blob/master/project-orga/MAINTAINERS.md