search

openhab / openhab-linuxpkg

Repo for Linux packages
Eclipse Public License 2.0
18 stars 33 forks source link

build does not work from Windows #92

Closed BClark09 closed 6 years ago

BClark09 commented 6 years ago

I'm not sure if anything can be done about this, every important file is replaced with Windows style line endings.

Twice I've fallen into the trap of building a change on my windows machine, to thoroughly screw-up the state of dpkg on my linux machine when I go to test it.

Might be best to remove gradle.bat and simply expect that Linux packages should be built on Linux...

ThomDietrich commented 6 years ago

Not sure which direction we are talking. Are the Windows endings (CRLF) committed or are you copying them over? Git allows to define how files are committed, you can force LF-only.

BClark09 commented 6 years ago

It's gradle side I think. The copy task copies a file from the directory into the deb package, but it changes the line endings to whatever the OS uses.

ThomDietrich commented 6 years ago

Ah I see. That's why I'm using Vagrant machines for these kinds of tasks 😃

ThomDietrich commented 6 years ago

@BClark09 are we going to meet at the Smart Home Day?

BClark09 commented 6 years ago

Unfortunately not :disappointed:. It would have been good to meet up over what looks like will be a fantastic day! This time of the year is usually a really busy period for me though :weary:.

I hope the event (and your session) goes well, but I'm sure it will. :smiley:

ThomDietrich commented 6 years ago

Too bad 😉 Enjoy your weekend!!