openhab / openhab-mycroft

Mycroft skill for openHAB
Eclipse Public License 2.0
20 stars 45 forks source link

Change to using skill settings instead of old config #72

Closed umglurf closed 5 years ago

umglurf commented 5 years ago

In the release notes for Mycroft 19.8: MycroftSkill.config no longer exists. Any skill specific settings should be made using the settings.json in the skills folder. This PR changes the code to using skill settings. This also has the benefit of giving the user a way to configure openHAB server and port in the web gui.

mortommy commented 5 years ago

Great! Did you signed-off your work? Thank you

mortommy commented 5 years ago

Yes! Just saw it. Merge!