search

openhab / openhab-qnap-qpkg

openHAB Packages for QNAP NAS systems
Eclipse Public License 2.0
77 stars 21 forks source link

Fixed openHAB configuration path #15

Closed tomquist closed 7 years ago

tomquist commented 7 years ago

Actually instead of "openHAB2" the share the installation script is looking for is called "openHAB"

thopiekar commented 7 years ago

Hey @tomquist many thanks for your PR. There are rules by the OpenHAB maintainers, that every comm+it message ends with eg.: Signed-off-by: Thomas Karl Pietrowski <thopiekar@gmail.com> (github: thopiekar) That's why I can't merge this PR. Could you be so kind and make a new PR?

kaikreuzer commented 7 years ago

@thopiekar I think this PR can be considered for the small patch exception.

In general, there is no need for new PRs if sign-offs are missing - the branch can simply be updated (squashed) and force pushed, so that the PR afterwards contains the correct sign-off footers.

OpenHAB maintainers

It's "openHAB" ;-)

thopiekar commented 7 years ago

Good morning @kaikreuzer

oh, ok, but it depends whether the owner of the commits wants to squash them up. But yes, you are right this can be done like that every quickly.

Haha, sorry, it is still too early :see_no_evil:

tomquist commented 7 years ago

Hey @thopiekar, I changed my PR accordingly.

thopiekar commented 7 years ago

Hmm, well, but the idea is that you add your details in there. However, I'll merge it now.

Thanks again :wink:

tomquist commented 7 years ago

Ok, sorry for the confusion, I misinterpreted it as a kind of review process without looking into contribution rules. Tbh I don't understand the point in adding my own data there as it is already part of the commit metadata.