openhab / openhab-qnap-qpkg

openHAB Packages for QNAP NAS systems
Eclipse Public License 2.0
77 stars 21 forks source link

set timezone depending on system timezone #9

Closed Andy1402 closed 7 years ago

Andy1402 commented 7 years ago

Please see the issue. Without this line OpenHAB will work with summer time instead of winter time.

Fixes #8

thopiekar commented 7 years ago

Sounds good. Returns Europe/Amsterdam here.

Is there a way to see which timezone is currently used by OH2?

Thanks!

Andy1402 commented 7 years ago

I'm not sure if you can see the timezone in OH2 directly. But without this I see the wrong time in the log files. Furthermore I added the NTP thing and the following item: DateTime HeuteJetzt "Heutiges Datum [%1$tA, %1$td.%1$tm.%1$tY, %1$tT]" { channel="ntp:ntp:local:dateTime" }

In the sitemap I added the item: Text item=HeuteJetzt

In my sitemap is the same time shown as in the log files. Now, with this fix, it is the correct time.

thopiekar commented 7 years ago

Ok, good argument. I would merge this directly into the repository, but there is a little problem: Your commit misses a Signed-Off tag.

The maintainers of OH want these tags in the end of every commit message. For example the last one here: https://github.com/openhab/openhab-qnap-qpkg/commit/6280e181661da3f1d8908416820f55a8bf59118d

Could you be so kind any recreate this PR including the tag?

Thanks!

PS: Optionally add Fixes #8 in your commit. So when merged it will close your issue report, too.

Andy1402 commented 7 years ago

Sorry, I didn't get it. Which Signed-Off tag do you mean? I have seen the command line in other forums and it was included in my old qpkg for OH1.8.3, too. It is a part from the start procedure. In each case there was exactly this line without further tags. I'm not sure what you are missing exactly.

thopiekar commented 7 years ago

Do you see the last line in my commit message? Which starts with Signed-Off:? I exactly need this in your commit, too.

PS: Of course with your name, etc.

thopiekar commented 7 years ago

Haha, doch nicht so. Ich erledige das in Kürze für dich :wink:

Andy1402 commented 7 years ago

Hehe sorry that is my first time. I wrote in the code, first. Now it the Signed-Off-Tag is in the comment. Is it correct, now? :-)

thopiekar commented 7 years ago

Well, your PR now includes also commits with messages which are not valid (Without a Signed-Off: tag). I'll add your change now directly to the master branch and mention + thank you for your work in this commit of course!

thopiekar commented 7 years ago

I hope you are fine with that :smiley:

Andy1402 commented 7 years ago

Yupp, thank you ^^