search

openhab / openhab-syno-spk

openHAB Synology SPK Install Package
Eclipse Public License 2.0
161 stars 42 forks source link

Changes user info to create userdata folder before #114

Closed rkrausen closed 7 years ago

rkrausen commented 7 years ago

This change is Reviewable

cniweb commented 7 years ago

@rkrausen Why did you close your 4 PR?

rkrausen commented 7 years ago

There was a problem. The system shows me a Cross in one of 3 tests and i can't change/repair.

cniweb commented 7 years ago

Sorry, that´s normal. The continuous-integration/feram check work´s not fine. Can you make a new PR with all the 4 changes?

rkrausen commented 7 years ago

Can you explain how to combine these in 1 PR

Von: Christian Häussler notifications@github.com Gesendet: Donnerstag, 16. November 2017 18:03:43 An: openhab/openhab-syno-spk Cc: Rene Krausen; Mention Betreff: Re: [openhab/openhab-syno-spk] Changes user info to create userdata folder before (#114)

Sorry, that´s normal. The continuous-integration/feram check work´s not fine. Can you make a new PR with all the 4 changes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openhab/openhab-syno-spk/pull/114#issuecomment-344989809, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADwYINaIiQg3nif5RvIQT9xzY-NLsMsoks5s3GrugaJpZM4QV5Xk.

cniweb commented 7 years ago

You create a fork from this repository, then create a branch in your repository and make the 4 changes (commits). Then you make a pull request to my master.

cniweb commented 7 years ago

See: https://help.github.com/articles/github-flow/