openhab / openhab-syno-spk

openHAB Synology SPK Install Package
Eclipse Public License 2.0
161 stars 42 forks source link

Synology package permissions wrong #161

Closed manudar closed 4 years ago

manudar commented 4 years ago

The Synology package does not install because the permissions of the .sh scripts inside the spk file are wrong. I fixed it and it works. Please update the build process so the spk file is done properly. Here is a link to the fixed package https://www.dropbox.com/s/7hqvwvm15mlc87b/openHAB-2.5.0.000-syno-noarch-0.001.spk?dl=0

cniweb commented 4 years ago

Hi @manudar how can i do this in the build process? Here is the build script: https://github.com/openhab/openhab-syno-spk/blob/master/.travis.yml

manudar commented 4 years ago

Hi, to make it work, the scripts have to have execution rights. I assume that somehow you could save this in the repository (I know how to do it in SVN but no idea in git). Anyway I added a line to fix it in the script although it is not elegant, the correct solution would be to fix it in the repo. To make it robust against local users is good to use always user 0 group 0. This is the updated script, although the chmod would be beter to remove it and save the execution permissions in the repository.

language: bash sudo: false dist: trusty

script:

deploy: skip_cleanup: true provider: releases api_key: secure: $GH_TOKEN file:

notifications: email:

env: global: secure: Y+YeEYwigSr5pbHDcg5FGOQLFyra1XINk7+uZc1T7LvFeHrX4uT1h9Dg+8zy8WKh4nThEekgOP9RBDL717tbO1QoAyiA5/whEj7IOvBB3h6DdbmTi9vwHfbP2yE1mHKHPApfldgE2SjGuSb1+rzPpNgZ4wVSnDhViR+mnXSGH4e+6KUg8I0/MnBUb3JYUSlE5v7CcbZxyG8J0GUTOCBL0iOCsDtguCOvcpZw1Kkjp4X4amvrbpBFwRW8t/CnDPTO64ArKe068Gv2CmWbpcYV32awBF7qzTeBrvU/WjOFu4UfJ3I1maYSycReffUdihragqpajQjAf+LIj4+fbAk3Pr/8Sv4EeKz/MgPBzA76fGMNlTiSeikL75gpAKC8ExIaR+Oas10+W28dfSq9tiyodE3ULYxhhhIXRQJaNpGTS2CkOSQ8MSmn8gOb6Uv8DPJbSp3gkKB9mPW86hub8kGJ0yAVX6vlv4jov5vojtJ20Xc+UqcnE+Wke3hwM02A39W2+RUMMtENJfexpWvlVQ3XTDXimeX1qP8vZ1ib6uTb4WrBJWzbJLiTTpgp+Ao039pNj+U4JIdj9s9nPJrKN4tfWMiz3E6sFLnXvkr3WXu8o31OQk8iBRFIforyDqir2t2C8ht7hN9S1HgDCiIOdUrwZgNnyBma+pn/b3627cPb8M0=

El mié., 29 ene. 2020 a las 14:48, Christian Häussler (< notifications@github.com>) escribió:

Hi @manudar https://github.com/manudar how can i do this in the build process? Here is the build script: https://github.com/openhab/openhab-syno-spk/blob/master/.travis.yml

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/openhab-syno-spk/issues/161?email_source=notifications&email_token=ACZHVZI5KXVIDXB5WB7MM3DRAGCLHA5CNFSM4J7FPVF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHHUHY#issuecomment-579762719, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZHVZI6VGISUU3U52G5NQTRAGCLHANCNFSM4J7FPVFQ .