openhab / openhab-syno-spk

openHAB Synology SPK Install Package
Eclipse Public License 2.0
161 stars 42 forks source link

OpenJDK: Adding Java 11 into our package #176

Closed thopiekar closed 3 years ago

thopiekar commented 3 years ago

Synology dropped any Java package from their software repository in DSM. It is unknown whether they will ever add Java at all. As OpenHAB itself recommends specific version(s) of Java for installation, I'm adding this feature not only to get independent of Synology, but also to get back full control over our installation.

This work has not been tested. Some corrections might follow.

Signed-off-by: Thomas Karl Pietrowski thopiekar@gmail.com (github: thopiekar)


This change is Reviewable

cniweb commented 3 years ago

Hi @thopiekar thank you, for your commit, but sign-off your commit, please: https://github.com/openhab/openhab-syno-spk/pull/176/checks?check_run_id=1543277017

thopiekar commented 3 years ago

Is included everywhere. Is DCO picky? I don't see a mistake. Signed-off-by: Thomas Karl Pietrowski <thopiekar@gmail.com> (github: thopiekar)

thopiekar commented 3 years ago

Adding this is a bad idea actually. I only download the x86_64 version and don't care about other architectures. Will be improved in the scope of #178 . Oh, that's another addition: There is no Java on DSM 7.