openhab / openhab-syno-spk

openHAB Synology SPK Install Package
Eclipse Public License 2.0
161 stars 42 forks source link

PIDFILE never defined ? #57

Closed ms777 closed 7 years ago

ms777 commented 7 years ago

Minor issue: In start-stop-status.sh, $PIDFILE is referenced a couple of times to check if openhab is running. It seems that $PIDFILE is never created, though. On my synology, /var/services/homes/openhab2 does not contain such a file even when openhab is running. Nonetheless, everything works fine ...

cniweb commented 7 years ago

Which package do you use?

ms777 commented 7 years ago

I use https://github.com/openhab/openhab-syno-spk/releases/tag/2.0.0.001-DSM6. 2.1.0.002-SNAPSHOT-DSM6 did not work for me (Windows 10, DSplay 214)

Even in the most recent version (https://github.com/openhab/openhab-syno-spk/blob/master/scripts/start-stop-status.sh), there is nothing in the 'start)' section, where a PIDFILE is created

I am a Linux newbie, so forgive me if this is bs.

cniweb commented 7 years ago

@ms777 can you try my new version: https://github.com/openhab/openhab-syno-spk/releases/tag/2.1.0.004-SNAPSHOT-DSM6

ms777 commented 7 years ago

the new version works, OpenHAB2 is installed and can be run.

Unfortunately, so far there seems to be some issue with recognizing the /volume1/public/openHAB2/conf folder. It is linked ...

admin@DiskStation:/volume1/@appstore/openHAB2$ ls -al
total 56
drwxr-xr-x  4 openhab2 root   4096 Mar 26 17:28 .
drwxrwxrwx 21 root     root   4096 Mar 26 17:27 ..
lrwxrwxrwx  1 openhab2 root     31 Mar 26 17:28 addons -> /volume1/public/openHAB2/addons
lrwxrwxrwx  1 openhab2 root     29 Mar 26 17:28 conf -> /volume1/public/openHAB2/conf
-rwxrwxrwx  1 openhab2 users 11232 Mar 25 12:23 LICENSE.TXT
drwxrwxrwx  6 openhab2 users  4096 Mar 26 17:28 runtime
-rwxrwxrwx  1 openhab2 users   121 Mar 25 12:17 start.bat
-rwxrwxrwx  1 openhab2 users    72 Mar 25 12:17 start_debug.bat
-rwxr-xr-x  1 openhab2 root   1132 Nov 17  2013 start_debug_runtime.sh
-rwxrwxrwx  1 openhab2 users    73 Mar 25 12:17 start_debug.sh
-rwxr-xr-x  1 openhab2 root    930 Nov 17  2013 start_runtime.sh
-rwxrwxrwx  1 openhab2 users   116 Mar 25 12:17 start.sh
-rwxr-xr-x  1 openhab2 root     65 Nov 17  2013 stop_runtime.sh
drwxrwxrwx  5 openhab2 users  4096 Mar 26 17:28 userdata

... but completely ignored by openHAB2. See the openhab.log:

admin@DiskStation:/volume1/@appstore/openHAB2$ cat userdata/logs/openhab.log
2017-03-26 17:30:06.240 [WARN ] [org.apache.felix.fileinstall        ] - /volume1/@appstore/openHAB2/addons does not exist, please create it.
2017-03-26 17:30:06.306 [WARN ] [org.apache.felix.fileinstall        ] - Root path does not exist: /volume1/@appstore/openHAB2/addons
2017-03-26 17:30:51.312 [INFO ] [.dashboard.internal.DashboardService] - Started dashboard at /start
2017-03-26 17:31:06.259 [WARN ] [.core.internal.folder.FolderObserver] - Directory 'items' does not exist in '/volume1/@appstore/openHAB2/conf'. Please check your configuration settings!
2017-03-26 17:31:06.262 [WARN ] [.core.internal.folder.FolderObserver] - Directory 'persistence' does not exist in '/volume1/@appstore/openHAB2/conf'. Please check your configuration settings!
2017-03-26 17:31:06.264 [WARN ] [.core.internal.folder.FolderObserver] - Directory 'rules' does not exist in '/volume1/@appstore/openHAB2/conf'. Please check your configuration settings!
2017-03-26 17:31:06.267 [WARN ] [.core.internal.folder.FolderObserver] - Directory 'scripts' does not exist in '/volume1/@appstore/openHAB2/conf'. Please check your configuration settings!
2017-03-26 17:31:06.269 [WARN ] [.core.internal.folder.FolderObserver] - Directory 'sitemaps' does not exist in '/volume1/@appstore/openHAB2/conf'. Please check your configuration settings!
2017-03-26 17:31:06.272 [WARN ] [.core.internal.folder.FolderObserver] - Directory 'things' does not exist in '/volume1/@appstore/openHAB2/conf'. Please check your configuration settings!

(these directories all exist in conf)

By mount --bind it works:

admin@DiskStation:/volume1/@appstore/openHAB2$ sudo rm conf
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo rm addons
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo mkdir conf
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo mkdir addons
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo mount --bind /volume1/public/openHAB2/conf conf
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo mount --bind /volume1/public/openHAB2/addons addons
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo chown -hR openhab2:users conf
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo chown -hR openhab2:users addons
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo chmod 777 conf
admin@DiskStation:/volume1/@appstore/openHAB2$ sudo chmod 777 addons
cniweb commented 7 years ago

The installation seems to work with the new release. Can we close this issue?

ms777 commented 7 years ago

o.k. for me to close, but I still believe the PIDFILE is never created