search

openhab / openhab-vscode

VS Code extension for openHAB configuration files
https://marketplace.visualstudio.com/items?itemName=openhab.openhab
Eclipse Public License 2.0
159 stars 47 forks source link

Open Sitemap directly #104

Closed Confectrician closed 6 years ago

Confectrician commented 6 years ago

Closes #38

As mentioned in the issue, i don't count the _default sitemap as valid for this logic and added a special exclusion for it. If someone has a different opinion feel free to share and discuss it here. 🙂

It works fine on my system.

Signed-off-by: Jerome Luckenbach github@luckenba.ch

kubawolanin commented 6 years ago

Hey Jerome, I finally had some time to take a look at this! I've checked out to your branch, tested it and added some small cleanup touches to the code :) Overall looks good to me. Let me know if you're ok with me merging this already.

Cheers, K

Confectrician commented 6 years ago

Looks good.

LGTM

kubawolanin commented 6 years ago

Thank you @Confectrician!