search

openhab / openhab-vscode

VS Code extension for openHAB configuration files
https://marketplace.visualstudio.com/items?itemName=openhab.openhab
Eclipse Public License 2.0
159 stars 47 forks source link

Work with local repository instead of shared folder #113

Closed PascalTurbo closed 4 years ago

PascalTurbo commented 5 years ago

After some help from the community I figured out, that the code validation only works when using a shared folder. So you need a specific development installation (what's hard to build up with different bus systems) or you have to work on your productive environment.

I think it would be better to support the option to work on a local repository and only use the openhab server vor code validation.

Confectrician commented 5 years ago

Can you point me to the community thread for a detailed overview?

The conditions for code validation are (or should be):

When those conditions are true, it shouldn't matter where your configuration files are located. I have tested this behavior with the current extension version and my configuration files, which i am managing through github.

I am working on a local copy, which then gets pushed to github and pulled afterwards into my production system. The code validation is working fine, on my local copy.

If it doesn't work in your case with local files, we should check the configuration and the conditions first.

Confectrician commented 5 years ago

Ah i think it is this one: https://community.openhab.org/t/vscode-doesnt-validate-my-code/55239/6

I will read through it to get an overview.

Confectrician commented 5 years ago

Ok now i am up to date.

Please notice that the problem is not really on VsCode side here. See eclipse/smarthome#6430 for reference.

I think it would be better to support the option to work on a local repository and only use the openhab server vor code validation.

So this was the case already some time ago and will hopefully be fixed soon in the eclipse smarthome repository again.

Are you fine with closing this issue and do all of the discussion in the eclipse smarthome repo to keep all relevant informations in one place?

PascalTurbo commented 5 years ago

Ah i think it is this one: https://community.openhab.org/t/vscode-doesnt-validate-my-code/55239/6

I will read through it to get an overview.

PascalTurbo commented 5 years ago

Ok now i am up to date.

Please notice that the problem is not really on VsCode side here. See eclipse/smarthome#6430 for reference.

I think it would be better to support the option to work on a local repository and only use the openhab server vor code validation.

So this was the case already some time ago and will hopefully be fixed soon in the eclipse smarthome repository again.

Are you fine with closing this issue and do all of the discussion in the eclipse smarthome repo to keep all relevant informations in one place?

The topic is getting off topic very fast, so we are talking about a different behavior. I'm on 2.3 Stable release where validation works correct - but not on my local folder.

I've checkt it again and maybe I've misinterpreted the results the first time. But now I've found the problem:

If you open the "conf" folder directly in VSCode (doesn't depend if its located locally or on the share) validation doesn't work. But if you open the overlying folder, that contains the "conf" folder as its subfolder, validation works remotely and locally.

Confectrician commented 5 years ago

I have testet this behavior and can't confirm that.

This is local and the direct conf folder structure. image

This is remote/share and the direct conf folder structure. image

A am on:

OS: Windows 10 VsCode: 1.28.2 openHAB Extension: 0.4.0 (latest) openHAB: 2.3.0 Release Build

Please post your setup, so we can find out a difference maybe.

PascalTurbo commented 5 years ago

I'm on:

OS: MacOS 10.14 Mojave VSCode: 1.28.2 openHAB Extension: 0.4.0 (latest) openHAB: 2.3.0 Release Build

So the difference seems to be the OS

Confectrician commented 5 years ago

Yep that could already be the reason, since the issue in eclipse smarthome also speks from different handling of file paths.

Maybe we should follow up that issue and leave this one open for reference. From my view this doesn't seem to be unrelated/off topic.

Confectrician commented 4 years ago

Hey @PascalTurbo,

The related smarthome issue was closed some time ago. Are you still facing problems?

If not i would then close this issue for now.

Confectrician commented 4 years ago

No reaction for 15 Days -> Closing now. If its still unsolved, we can reopen it again.