search

openhab / openhab-vscode

VS Code extension for openHAB configuration files
https://marketplace.visualstudio.com/items?itemName=openhab.openhab
Eclipse Public License 2.0
159 stars 47 forks source link

Removed sorting of items for auto completion #114

Closed SamuelBrucksch closed 5 years ago

SamuelBrucksch commented 5 years ago

vscode deals with sorting the items in the auto completion list so no need to do it here. Might improve speed a bit if this does not have to be done on each request.

Not sure if i miss something. If i do please illuminate me.

SamuelBrucksch commented 5 years ago

related to https://github.com/openhab/openhab-vscode/issues/95

I have some more ideas to improve auto completion speed, however i need to investigate if they work out.

Confectrician commented 5 years ago

Hi @SamuelBrucksch,

I am not a pro in debugging PR code, so please give me some time. (Kuba did the most work here and i am finding myself into the typescipt/extension stuff alone currently.)

One thing i can already tell you, is that you need to add a sign off statement to your commit. (If you need help with that git stuff, write me an answer here.)

See our Contribution Guidelines for more informatoin about signing of and what is needed to merge something into openHAB repositories.

BR Jerome

Confectrician commented 5 years ago

Hey @SamuelBrucksch,

I had a look in the debugger and would like to merge this one. Do you need any additional information for dooing the sign off statement?

BR Jerome

SamuelBrucksch commented 5 years ago

Hey, will look into it tomorrow or the day after. Cheers Sam

SamuelBrucksch commented 5 years ago

Hi,

i added the signed by and also tried it with git commit --signoff but the check still fails. Am i doing something wrong here? Is it maybe because of the push -f and i should add another commit?

BR Samuel

Confectrician commented 5 years ago

Hm,

No Idea why it still stucks. Maybe the force did confuse it. But pullaprove is just a check. Thankfully the mighty git gods gave me some accesses to overrule that.

The sign-off looks good to me, so LGTM.

SamuelBrucksch commented 5 years ago

Thanks, will check again later if it works on a new PR. Maybe there was something wrong in here because i ammended the sign off.

Confectrician commented 5 years ago

Ammend should be the correct way.

But you have 2 sign off statements in the first commit. The last one is the one with the "users.github" email. Maybe this blocks the pullapprove mechanism. I don't know if pullapprove allows github noreply email adresses.

If you do the signoff directly you shouldn't have problems. Works for me since ages.

Just check if your get config is up to date git config user.name & git config user.email and git commit -s -m "MYCOMMITMESSAGE" should work fine and append the sign off part.