search

openhab / openhab-vscode

VS Code extension for openHAB configuration files
https://marketplace.visualstudio.com/items?itemName=openhab.openhab
Eclipse Public License 2.0
159 stars 47 forks source link

Update pullapprove to version 3 api #151

Closed Confectrician closed 4 years ago

Confectrician commented 4 years ago

Pullapprove provides a new api version in which the yaml confic changed significantly. We should migrate to version 3 api config and remove the sign-off part.

Sign off is done through DCO bot anyways already.

kaikreuzer commented 4 years ago

What do we use Pullapprove for? I only remember that we used it for sign-off checks before switching to DCO.

Confectrician commented 4 years ago

From the current settings it is used for sign-off process and approving via comment. We could also remove it, but i wanted to check the capabilities first.

It can also do some auto answering on specific conditions. If there's nothing from interst after reaserch, i would remove it.

kaikreuzer commented 4 years ago

If there's nothing from interst after reaserch, i would remove it.

Afair, that was the outcome the last time someone looked into it. But feel free to check, if you find anything useful :-) .

Confectrician commented 4 years ago

After a short look i would go for a removal too. :) Some of the features could be interesting, but not for this small repo with that few maintainers.