openhab / openhab-vscode

VS Code extension for openHAB configuration files
https://marketplace.visualstudio.com/items?itemName=openhab.openhab
Eclipse Public License 2.0
159 stars 47 forks source link

Internal Error #173

Open Confectrician opened 5 years ago

Confectrician commented 5 years ago

Sometimes the extension throws an internal error with no other useful information.

Expected Behavior

Extension should startup without errors in any case. If there are errors occuring from wherever, the extension should handle them appropriate and produse some useful warnings/notifications/logs.

Current Behavior

Extension Throws an internal error, mainly when connected to a unmounted network path.

Possible Solution

From a first fast debug this seems to be caused by the remote lsp implementation. -> So it could be related to: openhab/openhab-core#1171 and maybe already solved in some future version.

Anyway we should make sure that the extension throws no error in such a case, but handles the exception properly with some useful output for a user, which can than be referenced in an issue her on github or in the community.

Steps to Reproduce (for Bugs)

  1. Open vscode
  2. Connect a network path

Context

https://community.openhab.org/t/solved-on-every-start-internal-error-source-openhab-extension/66844?u=confectrician

Your Environment

Confectrician commented 5 years ago

From what i have seen the error is thrown from our remote lsp server and handled by the vscode rpc library. But i have no idea how to handle it, when we cant catch it from the extension self.