openhab / openhab-vscode

VS Code extension for openHAB configuration files
https://marketplace.visualstudio.com/items?itemName=openhab.openhab
Eclipse Public License 2.0
159 stars 47 forks source link

use custom folder icon for `icons/classic` #206

Closed CWempe closed 4 years ago

CWempe commented 4 years ago

I noticed the icons/classic folder does not have the custom icon of the icons folder.

image

Since icons/classic seems to exist by default, I would suggest to use the custom icon for this folder, too.

If you agree I could extend the openhab-icon-theme.json and create a PR.

Like:

    "folderNames": {
        "icons": "_folder_icons",
        "classic": "_folder_icons",

    "folderNamesExpanded": {
        "icons": "_folder_open_icons",
        "classic": "_folder_open_icons",

This would apply for all folders named classic, no matter the parent fodler.. So I don't know if this would be the best solution.

Confectrician commented 4 years ago

Fine for me. :) Let's go, i will assign you.

CWempe commented 4 years ago

Fixed. #207

image