search

openhab / openhab-vscode

VS Code extension for openHAB configuration files
https://marketplace.visualstudio.com/items?itemName=openhab.openhab
Eclipse Public License 2.0
159 stars 47 forks source link

Review usage of workspaceContains activationEvent #215

Closed roblourens closed 3 years ago

roblourens commented 3 years ago

Hi, I'm reaching out to let you know that we are fixing a bug with the workspaceContains VS Code extension activationEvent that could change the activation behavior for your extension.

Here's the issue: This event is supposed to start a search in the user's workspace with the given glob pattern, and activate the extension if it finds a match. A pattern like *.txt should find a file in the root of the workspace matching *.txt, but it should not search the entire workspace. A pattern like **/*.txt should recursively search the entire workspace. We discovered that VS Code is incorrectly applying the ** pattern to every workspaceContains pattern that includes a *.

Since this may impact the startup performance of VS Code, we need to scope these searches correctly. Once we fix this, a pattern like *.txt will only match a .txt file in the root of the workspace.

The change will be in VS Code Insiders in early January. It will be released with 1.53 in early February. Please see https://github.com/microsoft/vscode/issues/110510 for more details and let me know if you have any questions.

Confectrician commented 3 years ago

Thanks for reaching out. :)

Confectrician commented 3 years ago

Hello @roblourens and thanks again for reaching out here. 👍 Probably you had too file several issues of this kind.

I have checked the situation for this extension and we should be safe and not affected from this issue. Therefore closing this issue.