search

openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
218 stars 238 forks source link

"Add-on Management" not translated #1669

Open lolodomo opened 1 year ago

lolodomo commented 1 year ago

In settings page, all system services are correctly translated except "Add-on Management". image

The translation seems to be correctly defined: https://github.com/openhab/openhab-core/blob/main/bundles/org.openhab.core/src/main/resources/OH-INF/i18n/addons_fr.properties#L6

Now, when I open this page, the parameters are properly translated except the title "Add-on Management": image

florian-h05 commented 1 year ago

Given that this part of the settings page is generated based on the API response from core, see:

https://github.com/openhab/openhab-webui/blob/5b680e3a0811d8d8e6eb05b9e9226bfe02ec7a26/bundles/org.openhab.ui/web/src/pages/settings/settings-menu.vue#L121-L125

I’d say this is some core issue. You can check what the API returns for /rest/services.

lolodomo commented 1 year ago

Result of GET /services

image

All services are translated except one. So you are right, the problem is in core framework, not in MainUI.

florian-h05 commented 1 year ago

Okay, let‘s move this to core.

@kaikreuzer Can you please transfer this to core?

lolodomo commented 1 year ago

I am not sure but the problem could be that the files addons.properties and addons_*.properties are in org.openhab.core bundle and not in the bundle containing the service. I don't know why they are in this bundle. The code is searching the translation in the bundle of the service: https://github.com/openhab/openhab-core/blob/main/bundles/org.openhab.core.io.rest.core/src/main/java/org/openhab/core/io/rest/core/internal/service/ConfigurableServiceResource.java#L310