search

openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
225 stars 242 forks source link

Sip Client Card use to much Space if video is acticated. #1678

Open DeBaschdi opened 1 year ago

DeBaschdi commented 1 year ago

The problem

Sip Client Card use to much Space if video is acticated.

IDLE:

idle_state

While Calling :

while_calling

Your suggestion

It would be nice, if this widget only display the status Icon, after accepting a Call, or Take a Call a popup should open with Video and an option to send DTMF / Hang Up .

Your environment

Additional information

florian-h05 commented 1 year ago

If one wants to start implementing that (it should be done by someone who can test the video popup, not sure if I can - my SIP server doesn’t support that), the original code of the sipclient component could be a great help.

Some history: The original codebase was in fact using an popup for the call (not sure if only video or audio as well), but I completely redesigned the SIP client to „match“ with the other MainUI components and removed video support because I couldn’t test it. @digitaldan added video support back, but he decided (? not sure if he thought about this or just chose my design way) to not use a popup.

The SIP client code was originally written by @hubsif and is still at his repo: https://github.com/hubsif/openhab-webui/commit/c5b8abe370858bddb646ab6b241f20c7237eef40.

digitaldan commented 1 year ago

So i just added video support to the current widget, was not aware of the original popup design, or at least i don't remember it. Probably not a problem to add that as a feature, i'll take a look.

DeBaschdi commented 1 year ago

I might have one or the other useful idea.

For me it would be nice if an option could be built in which a live image (Thumbnail URL) sends as a popup even while ringing. (can be activated / deactivated in the widget settings)

The call should then be able to be accepted/rejected in the pop-up or the door opened directly (DTMF send).

Assuming the call is accepted, the live video should start, also with the End Call / DTMF Send option.

And while I'm at it, possibly also a "snooze" switch that can mute the ringing so as not to be disturbed.

florian-h05 commented 1 year ago

For me it would be nice if an option could be built in which a live image (Thumbnail URL) sends as a popup even while ringing.

I don't think that this will get implement - I think you can build this yourself using the oh-sipclient, the oh-image and maybe some other components in a custom widget. Using expressions, you can dynamically set properties of these components according to Item state etc. Another option would be to check the marketplace - maybe someone already build something similar. See https://next.openhab.org/docs/ui/personal-widgets.html#the-expression-syntax, https://next.openhab.org/docs/ui/building-pages.html, https://next.openhab.org/docs/ui/components/.

And while I'm at it, possibly also a "snooze" switch that can mute the ringing so as not to be disturbed.

May be an idea, but this could make the widget a bit overloaded.

DeBaschdi commented 1 year ago

Hi Florian, that was just an idea, it would then also correspond to the functionality of a normal video intercom station, with a Fritz Phone, for example, a picture of the visitor comes first / while ringing.

I can't judge whether it's possible to create your own widget, at least I don't see myself able to do so.

But I would like to support this project with a donation, if someone is up for it, I could provide a sandbox development environment in my LAN via VPN, Freepbx(asterisk) is already preconfigured with an Akuvox and could be used.