openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
221 stars 240 forks source link

Icon "player" from classic icon set broken #1768

Closed mueller-ma closed 11 months ago

mueller-ma commented 1 year ago

The problem

The text "Power on" from the SVG version of the icon "player" is broken in the PNG version:

Expected behavior

Both should look the same.

Steps to reproduce

  1. Open the links above.
lolodomo commented 1 year ago

We have the convert script (convert, sh) that converts all SVG in PNG. You could check if it fixes the player icon.

lolodomo commented 1 year ago

The .convert.sh script requires a Linux environment and the following tools: scour, rsvg-convert, optipng and pngquant.

lolodomo commented 1 year ago

Noone has a Linux DEV env to try to run the convert script (after installing the different required tools) ? Just to check if it fixes the player.png file ?

mueller-ma commented 1 year ago

Actually you need Docker to run the script: https://github.com/openhab/openhab-webui/blob/main/bundles/org.openhab.ui.iconset.classic/Dockerfile#L6

This way the tool versions are independent of the developer machine and the outcome should always be the same.