search

openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
213 stars 233 forks source link

[blockly] Fix multilineedit rendering issue #2496

Closed stefan-hoehn closed 2 months ago

stefan-hoehn commented 2 months ago

Finally the long awaited fix for the dreaded blockly multilineedit rendering issue like the following

image

more info can be found at: https://github.com/google/blockly-samples/issues/2235

The solution is to make sure that the hidden textarea style neither has a background of none or transparent.

relativeci[bot] commented 2 months ago

Job #1853: Bundle Size — 10.55MiB (~+0.01%).

90d8fa8(current) vs 577568d main#1852(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1853		      Baseline
Job #1852
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 18.23% 17.81%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2856 2856
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 94 94
No change  Duplicate Packages 2 2

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[Job #1853](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #1852](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1852-ohU794r8ayqIj4SX9La2?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `8.74MiB` | `8.74MiB` | | Regression  [CSS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `890.03KiB` (`~+0.01%`) | `889.97KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `526.1KiB` | `526.1KiB` | | Not changed  [Media](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-1_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View Media assets") | `295.6KiB` | `295.6KiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `140.74KiB` | `140.74KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `1.24KiB` | `1.24KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1853-035jqGIIhqdfJmkLe8Zw/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `871B` | `871B` |

View job #1853 report View stefan-hoehn:blockly_fix_multili... branch activity View project dashboard

florian-h05 commented 2 months ago

I just discovered an issue with the dark mode (white text on white background doesn't work very well ;-)), but this can be easily fixed:

textarea.blocklyHtmlTextAreaInput
  background #ffffff
  color #000000
stefan-hoehn commented 2 months ago

Yes, true, that one will work on dark mode as well:

image