openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
212 stars 232 forks source link

Thing details: Fix code tab not editable #2526

Closed florian-h05 closed 1 month ago

florian-h05 commented 1 month ago

Fixes #2523.

Regression from one of the previous PRs to the Thing details page.

This is a timing issue similar to #2375, where the code editor is initialized as read-only because the Thing is not loaded yet. After initialisation, the editor can not be set to read-write.

relativeci[bot] commented 1 month ago

Job #1888: Bundle Size — 10.56MiB (~+0.01%).

ec3ae3c(current) vs 0449e51 main#1886(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #1888
     Baseline
Job #1886
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
No change  Cache Invalidation 18.3% 18.3%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2861 2861
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 95 95
No change  Duplicate Packages 2 2

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[Job #1888](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #1886](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1886-mPVCrRWQ9lZUL42skmME?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `8.75MiB` (`~+0.01%`) | `8.75MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `890.07KiB` | `890.07KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `526.1KiB` | `526.1KiB` | | Not changed  [Media](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-1_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View Media assets") | `295.6KiB` | `295.6KiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `140.74KiB` | `140.74KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `1.24KiB` | `1.24KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1888-2m1YHBvWEFr09j7XAU6c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `871B` | `871B` |

View job #1888 reportView thing-details branch activityView project dashboard

kaikreuzer commented 1 month ago

@florian-h05 Do I understand your comment on https://github.com/openhab/openhab-webui/issues/2523 correctly that this should better not be merged for M2 as it is untested?

florian-h05 commented 1 month ago

I expect it to fix the issue as it is similar to the other linked PR, but I can’t verify that it really fixes the issue as I can’t test. However I don’t think there will be a regression from this PR, so it should be safe to merge. It might not solve the issue though.

kaikreuzer commented 1 month ago

Ok, thanks. So if there is no risk through it, let's merge and see if it fixes the issue.