search

openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
212 stars 232 forks source link

Metadata: Add `link_to_more` as well-known namespace #2543

Closed florian-h05 closed 3 weeks ago

florian-h05 commented 3 weeks ago

Closes #2382. Refs https://github.com/openhab/openhab-android/issues/3140.

Adds Android app's link_to_more metadata to the well-known namespaces, therefore also adds an editing page for it.

Screenshots ![image](https://github.com/openhab/openhab-webui/assets/73423173/1545e754-b891-4fb9-8f58-e501b14d4eef) ![image](https://github.com/openhab/openhab-webui/assets/73423173/c06ac1bb-4bbc-467c-b82a-d76835af89ee)
florian-h05 commented 3 weeks ago

@mueller-ma Please let me know what you think about the label and the description (have a look at the screenshots, which are behind the expandable "Screenshot").

relativeci[bot] commented 3 weeks ago

Job #1908: Bundle Size — 10.56MiB (~+0.01%).

ee5d617(current) vs 2de1521 main#1905(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
Job #1908		      Baseline
Job #1905
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 18.48% 17.88%
No change  Chunks 223 223
No change  Assets 246 246
Change  Modules 2864(+0.1%) 2861
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 95 95
No change  Duplicate Packages 2 2

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[Job #1908](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #1905](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1905-v3zUEIW7VrYV40UbBPqW?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `8.75MiB` (`+0.01%`) | `8.75MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `890.07KiB` | `890.07KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `526.1KiB` | `526.1KiB` | | Not changed  [Media](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-1_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View Media assets") | `295.6KiB` | `295.6KiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `140.74KiB` | `140.74KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `1.24KiB` | `1.24KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1908-HSeg3AqTc09FhMOdwjGl/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `871B` | `871B` |

View job #1908 report View florian-h05:metadata_linktomore branch activity View project dashboard

florian-h05 commented 3 weeks ago

@mueller-ma Thanks for the suggestions, I have applied them all. I will merge this PR once checks passed.

mueller-ma commented 3 weeks ago

Thanks for implementing it. Looks good so far beside my last comment.