relativeci[bot]
commented
2 weeks ago #1943 Bundle Size — 10.59MiB (+0.02%).
725e626(current) vs 50f2a91 main#1941(baseline)
[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages
Bundle metrics
1 change
| Current #1943 |
Baseline #1941 |
|
|---|---|---|
 Initial JS |
1.86MiB |
1.86MiB |
| Initial CSS |
607.87KiB |
607.87KiB |
| Cache Invalidation |
17.76% |
17.77% |
| Chunks |
222 |
222 |
| Assets |
245 |
245 |
| Modules |
2873 |
2873 |
| Duplicate Modules |
146 |
146 |
| Duplicate Code |
1.84% |
1.84% |
| Packages |
95 |
95 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| | Current
[#1943](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe?utm_source=github&utm_medium=pr-report "View bundle analysis report") | Baseline
[#1941](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1941-EB9ggx2F5PcnqlqsuwM8?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| |
[JS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `8.78MiB` (`+0.02%`) | `8.77MiB` |
| [CSS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `890.63KiB` | `890.63KiB` |
| [Fonts](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `526.1KiB` | `526.1KiB` |
| [Media](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-1_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View Media assets") | `295.6KiB` | `295.6KiB` |
| [IMG](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `140.74KiB` | `140.74KiB` |
| [HTML](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `1.24KiB` | `1.24KiB` |
| [Other](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1943-Tp6p3tNG37mJKxIE8Fbe/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `871B` | `871B` |
Bundle analysis report Branch mherwege:press_release_button Project dashboard
lolodomo
mherwege
Related to https://github.com/openhab/openhab-core/pull/4183 Requires https://github.com/openhab/openhab-core/pull/4204
This PR implements press/release button support.
To make this work, some refactoring had to be done to allow proper quoting of arguments in mappings and conditions. So far, quotes where stripped and the full mapping or condition strings where interpreted by splitting on special characters (=, : ...). This is limiting as it blocks these characters from being used in the arguments or makes working with blanks difficult. The sitemap syntax explicitely works with quoted strings for this, but that information was lost in the current implementation. Quotes are now preserved, and therefore they need to be removed in core at usage (https://github.com/openhab/openhab-core/pull/4204). Note that this introduced a backward compatibility constraint, as sitemaps saved in the UI, containing mappings or conditions with blanks, will require quotes to be manually added in the UI in order to be able to save changes to it. If not touched, the sitemaps should still work.