search

openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
212 stars 232 forks source link

Sitemap editor: Fix buttongrid editor #2554

Closed mherwege closed 2 weeks ago

mherwege commented 2 weeks ago

Fields should use all space available. In a button grid definition the row and column fields where not visible.

I can't say what caused this, but this PR should fix this.

relativeci[bot] commented 2 weeks ago

#1918 Bundle Size — 10.57MiB (~-0.01%).

a1be1a4(current) vs 3396a4f main#1915(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#1918		      Baseline
#1915
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.78% 17.65%
No change  Chunks 222 222
No change  Assets 245 245
No change  Modules 2866 2866
No change  Duplicate Modules 143 143
No change  Duplicate Code 1.83% 1.83%
No change  Packages 95 95
No change  Duplicate Packages 2 2

Bundle size by type  Change 1 change Improvement 1 improvement
|            |       Current
[#1918](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#1915](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1915-b9numTBpoXvo6FNwtS90?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Improvement  [JS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `8.76MiB` (`~-0.01%`) | `8.76MiB` | | No change  [CSS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `890.07KiB` | `890.07KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `526.1KiB` | `526.1KiB` | | No change  [Media](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-1_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View Media assets") | `295.6KiB` | `295.6KiB` | | No change  [IMG](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `140.74KiB` | `140.74KiB` | | No change  [HTML](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `1.24KiB` | `1.24KiB` | | No change  [Other](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1918-XMyJGBZQQrg0CRlZqGUy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `871B` | `871B` |

Bundle analysis report Branch mherwege:button_config_fix Project dashboard