openhab / openhab-webui

Web UIs of openHAB
Eclipse Public License 2.0
212 stars 232 forks source link

Setup wizard: Fix already set i18n settings not respected #2559

Closed florian-h05 closed 2 weeks ago

florian-h05 commented 2 weeks ago

Fixes https://github.com/openhab/openhab-core/issues/4105.

The setup wizard did not respect the i18n config file's content, which resulted in overwriting the existing i18n settings.

relativeci[bot] commented 2 weeks ago

#1936 Bundle Size — 10.58MiB (~+0.01%).

63b0752(current) vs 6f5a59f main#1935(baseline)

[!WARNING] Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#1936
     Baseline
#1935
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
No change  Cache Invalidation 17.78% 17.78%
No change  Chunks 222 222
No change  Assets 245 245
No change  Modules 2873 2873
No change  Duplicate Modules 146 146
No change  Duplicate Code 1.84% 1.84%
No change  Packages 95 95
No change  Duplicate Packages 2 2

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[#1936](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#1935](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1935-qRJpGMKGROXSGe8wHKyu?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `8.77MiB` (`~+0.01%`) | `8.77MiB` | | No change  [CSS](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `890.63KiB` | `890.63KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `526.1KiB` | `526.1KiB` | | No change  [Media](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-1_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View Media assets") | `295.6KiB` | `295.6KiB` | | No change  [IMG](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `140.74KiB` | `140.74KiB` | | No change  [HTML](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `1.24KiB` | `1.24KiB` | | No change  [Other](https://app.relative-ci.com/projects/ZNG5hy4VeSJQVQcq1Kvu/jobs/1936-P65nRSoc6zV5ibD8t2Fv/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `871B` | `871B` |

Bundle analysis reportBranch florian-h05:setup-wizardProject dashboard