openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.69k forks source link

Artnet DMX binding ignores configuration settings #1182

Closed ghost closed 9 years ago

ghost commented 10 years ago

The Artnet Dmx binding does not use the ip address provided in the configuration file. Instead it is defaulting to localhost:9010. The issue is specifically the open() method. Honestly you probably could just reuse the code under the OLA binding.

Log:

21:16:23.123 DEBUG o.o.b.d.a.ArtnetConnection[:59]- artnet-config: localhost:9010
21:16:23.123 DEBUG o.o.b.d.a.ArtnetConnection[:63]- adding artnet receiver localhost:9010

Current DMX Config

################################# DMX Binding #########################################
#
# The combined connection String, e.g. 'localhost:9010' (optional, defaults to
# 'localhost:9010' or 'localhost:9020' depending on the choosen connection type)
#dmx:connection=192.168.1.121
lostcontrol commented 10 years ago

And if you change your config to:

################################# DMX Binding #########################################
#
# The combined connection String, e.g. 'localhost:9010' (optional, defaults to
# 'localhost:9010' or 'localhost:9020' depending on the choosen connection type)
dmx:connection=192.168.1.121

Do you see any improvements?

ghost commented 10 years ago

Yes, it functions as it is supposed to, when # is the removed from the config file.