openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.7k forks source link

Several Actions aren't properly resolved in Designer #1403

Closed udo1toni closed 9 years ago

udo1toni commented 10 years ago

Although I copied the action-file to Designer/addons-folder, the actions aren't recognized in the rules-files. So the designer shows errors, where aren't errors at all, also the auto completion does not work (evident) This Problem exist at least with Win7-64, Oracle Java7u67-32 and with openHAB nightly build 716 or older. With the same Installation, xmpp-action works as expected, so I think, the problem could be in squeezebox-action-file.

See also http://knx-user-forum.de/openhab/35875-designer-meckert-squeezebox-actions.html

udo1toni commented 10 years ago

Sounded so good ... but #1485 doesn't seem to solve my problem - at least in Snapshot#739. In fact, Designer resolves the xmpp-Action, no matter if there is an xmpp-actions-File in openHSB-Designer/addons/ or not, and doesn't resolve the squeezebox-actions at all. Sorry for I hadn't checked that behavior before.

udo1toni commented 9 years ago

Question: Do I have to import something to rulefile, to make correct use of squeezebox-actions? (Maybe something like import org.openhab.action.squeezebox ? - no - this import does not solve the problem, but...)

staehler commented 9 years ago

I've the same problem unfortunately. Is there no hint, how to get rid of this anoying errors? Meanwhile this false errors lead to overlook real faults.

teichsta commented 9 years ago

so you are working with 1.7 SNAPSHOT, right?

staehler commented 9 years ago

Thats correct. I have the build number not at my hand, but it's quite recent (this week)

Gesendet mit AquaMail für Android http://www.aqua-mail.com

Am 17. April 2015 15:24:36 schrieb Thomas Eichstädt-Engelen notifications@github.com:

so you are working with 1.7 SNAPSHOT, right?


Reply to this email directly or view it on GitHub: https://github.com/openhab/openhab/issues/1403#issuecomment-93985120

teichsta commented 9 years ago

strange … when running the Designer from IDE the Squeezebox and xPL Action appear without any problems. So it seems to be an assembly problem …

staehler commented 9 years ago

Hi Thomas, hmm, do I need to include a special lib into my rules file? I get following error messages: Couldn't resolve reference to JvmIdentifiableElement 'squeezeboxPlayUrl'. or Couldn't resolve reference to JvmIdentifiableElement 'squeezeboxSpeak'. but the actions work well in openhab.

BTW I get such a error message for my.openhab actions ax´s well: Couldn't resolve reference to JvmIdentifiableElement 'sendNotification'.

teichsta commented 9 years ago

as i said it only works when starting the Designer out of the IDE. When running the binary i can reproduce the given problem

udo1toni commented 9 years ago

:) happy that you can reproduce it :)

lolodomo commented 9 years ago

Please note that we have the same issue with the MiOS actions too, at least with Designer1.6.2. I have not tested with Designer 1.7.0. So please check the MiOS actions too.

watou commented 9 years ago

The non-appearance of the new Ecobee actions in the Designer is also an issue. I have been looking for commonalities across the action bundles as to why some bundles' actions appear and some don't, but I have thus failed to find an explanation. The Ecobee actions do not appear whether the Designer is run standalone, or from the IDE. Also, the MiOS plugin is not listed in feature.xml, but adding it does not fix the problem.

lolodomo commented 9 years ago

Regarding the MiOS actions, I can see using Desinger 1.7 that no error are displayed when you open your rule file. But as soon as you try to modify one rule, errors come back. So the bug is not yet fixed in 1.7 for MiOS actions.

teichsta commented 9 years ago

so it seems several actions aren't working. I know of

anything else?

kaikreuzer commented 9 years ago

Well, looking at https://openhab.ci.cloudbees.com/job/openHAB/ws/products/org.openhab.designer.product/target/products/org.openhab.designer.product/win32/win32/x86/plugins/, I see that at least MiOS, EcoBee and my.openHAB are all not contained in the Designer, right?

marcelerkel commented 9 years ago

The HarmonyHub action is also missing in ./features/org.openhab.designer.feature/feature.xml

kaikreuzer commented 9 years ago

So to summarize: The Designer distribution is lacking the bundles

Then, although it includes Squeezebox action and xPL action, it is missing their depedencies on

I would assume that if all these were added, there weren't any problem.

teichsta commented 9 years ago

see #2967 which makes the above mentioned actions visible except my.openHAB

staehler commented 9 years ago

Not sure if this item fits here: Designer marks the CallType (Fritzbox-Binding) with this message: "Couldn't resolve reference to JvmType 'CallType'." and "Couldn't resolve reference to JvmIdentifiableElement 'origNum'."

var CallType call = Incoming_Call_No.state as CallType
var String caller = "" + call.origNum
var String callee = "" + call.destNum
teichsta commented 9 years ago

are you sure you've added an import org.openhab.library.tel.CallType in your rules file?

staehler commented 9 years ago

@teichsta Thanks for the hint. I've imported this lib but the designer message remains (after validating the code). BTW: the rule works, even without this imported lib.

teichsta commented 9 years ago

see #2967 - made all all Actions (except my.openHAB - added #2993 as follow-up) available in Designer