openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.69k forks source link

PR #2532 makes rrd4j service to depend on ConfigAdmin #2912

Open kaikreuzer opened 9 years ago

kaikreuzer commented 9 years ago

https://github.com/openhab/openhab/pull/2532 changed the rrd4j service in a way that it mandatorily requires to have the updated() method called through ConfigAdmin. Since this does not happen, if no configuration (or confadmin service) is provided, the service does not work as expected anymore in this case.

The default rrdDefs should be set outside the updated() method, so that they are available in any case.

@J-N-K Could you please have a look? Thanks!

P.S.: Opposed to my initial thoughts, this does not affect openHAB 2 negatively, so I reduced the severity - it is not blocking anymore.

J-N-K commented 7 years ago

doesn't #3125 fix this issue?