search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.69k forks source link

[Rollershutter] Bad implementation UP/STOP/DOWN commands (KNX) #4176

Open activenodes opened 8 years ago

activenodes commented 8 years ago

Hello!

There is a bad implementation of Rollershutter command (KNX), tested by web and also script (.rules)

This is the command for "UP" ..4/1/20 Home 6 Write $00 | Off

And this is the command for "STOP" ..4/1/21 Home (stop) 6 Write $00 | Off

It's right, $00 for first group (move) and $00 for the second group (stop)

Now...

This is the command for "DOWN" ..4/1/20 Home 6 Write $01 | On

This is the command for "STOP" ..4/1/21 Home (stop) 6 Write $00 | Off

Well, $01 for fist group (move) is correct, but $00 for second group (stop) is wrong. The right command for second group is $01 and not $00.

The actuator work (UP/STOP/DOWN/STOP) but the other modules remaing misaligned (last state/command/stop), ignoring this wrong command from OpenHAB.

Is it possible to fix? Thanks!

Sim

udo1toni commented 8 years ago

To be honest... knx does not know STOP as command for Blinds or Rollershutters at all, but then STEP (UP/DOWN), which is used as Stop Command, so stop is only one step away ;) It should be nonrelevant which one is used to stop as long as the Step duration is short enough.

activenodes commented 8 years ago

Hello!

Using "one button" device/setup for UP/STOP/DOWN/STOP it's important. In case of bad STOP, you need to press repeatedly hardware button for complete the cycle (fix bad command, stop and then move again).

If it's not possibile fix by OpenHAB code (but this is a bug) how to use rules for send specific command? Instead of: sendCommand(Rollershutter_A, STOP)

something like sendCommand(itemName, group:hex-value): sendCommand(Rollershutter_A, 4/1/21:$01)

In this way I can "fix" bad command sending the right by script/rules

Thanks

Sim

udo1toni commented 8 years ago

Ahh, I see. For me I never set up a one-ButtonRollershutter in knx although I have one :) I did this with a rule instead, which sends the 'stop' when long press is detected, obviously a dirty workaround 'cause I didn't realize I could use Rollershutter komplete with only one button...