search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.7k forks source link

Include Leviton VRS05-1LZ Switch in Z-Wave Database #4513

Open JohnCardenas opened 8 years ago

JohnCardenas commented 8 years ago

Hi @cdjackson, I'm looking to add another device, the Leviton VRS05-1LZ. The device is similar to the VRS15-1LZ, which is already in the database (this is the no-neutral wire version). I noticed that my switch has a different ID than the one in the online Z-Wave database. Just to confirm before I submit a PR, I need to add the device XML to the appropriate location in the repo (under openhab/bundles/binding/org.openhab.binding.zwave/database/(manufacturer)), then update the products.xml file with the identifying information, taking the device's Type and Id from HABmin, correct?

cdjackson commented 8 years ago

Is the VRS05 and VRS05-1LZ effectively the same device (forgetting the device IDs for a minute). I don’t know what the 1LZ means? Often we have multiple versions of what is effectively the same device, and we can just add the extra IDs to the existing device? That’s probably the easiest, and probably best way forward.

So, you’d only need to update the products.xml to add the extra IDs.

On 3 Jul 2016, at 22:36, John Cardenas notifications@github.com wrote:

Hi @cdjackson https://github.com/cdjackson, I'm looking to add another device, the Leviton VRS05-1LZ. The device is similar to the VRS15-1LZ, which is already in the database (this is the no-neutral wire version). I noticed that my switch has a different ID than the one in the online Z-Wave database http://www.cd-jackson.com/index.php/zwave/zwave-device-database/zwave-device-list/devicesummary/366. Just to confirm before I submit a PR, I need to add the device XML to the appropriate location in the repo (under openhab/bundles/binding/org.openhab.binding.zwave/database/(manufacturer)), then update the products.xml file with the identifying information, taking the device's Type and Id from HABmin, correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/openhab/issues/4513, or mute the thread https://github.com/notifications/unsubscribe/AA_kQ8UYg7CGHkkYVrWO5NFliv3FruGdks5qSCtsgaJpZM4JD9DD.

JohnCardenas commented 8 years ago

There is no mention of the VRS05 in the products.xml list. The VRS15-1LZ is the closest match, but it's a different model number entirely.