openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.69k forks source link

[Weather] Documentation problem about snow item unit #5487

Open emme-g opened 6 years ago

emme-g commented 6 years ago

Hello, in the place where I live is going to snow in the next hours, so I checked my Openhab2 system where I recently added more forecast item from the Weather binding to see if the precipitation-snow item would signal that and: yes, the number item is not null and gives me the information that I'm going to see outside a 0.5 mm/h snowfall! That 0.5 mm/h seemed to me a little bit too precise so I've checked in the binding documentation page and I found a contradiction in it:

cweitkamp commented 6 years ago

The snow volume is given in mm/h (see http://openweathermap.org/weather-data). OWM API returns a value for the next three hours. The binding converts it to one hour.

I will clean up the documentation.

cweitkamp commented 6 years ago

After looking into it I'm sure we have to do some more tweaking. The binding provides the data for snowfall for the following three providers: https://github.com/openhab/openhab1-addons/blob/eb78378754a8d8761f3cb9d52c7a31e45a5e7f2e/bundles/binding/org.openhab.binding.weather/src/main/java/org/openhab/binding/weather/internal/model/Precipitation.java#L36-L41

Weather Underground returns a value in cm / day, OpenWeaterMap returns a value in mm / 3h (is converted to mm / h by the binding) and HAMweather returns a value in mm (no information about any period). This has to be unified.

@emme-g Which weather provider do you use?

emme-g commented 6 years ago

Hi, thank you for taking care of this problem. I'm using Wunderground as weather data provider, so it means that the number I red yesterday in my item indicated a probability for a snowfall of about 0,5 cm (for all the day). I agree with you when you write that would be better to unify the information given by the binding, the meaning of the value shouldn't be affected from the chosen whether data provider. If that would result difficult to achieve, I think that at least that should be clearly documented. Let me know if I can help anyhow for this modification process (I'm not it-professional but I'm available if needed), and thank you again. Bye.