search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.69k forks source link

[fritzboxtr064] replaced the trim method, to get rid of white spaces in between the tel numbers #5656

Closed andre77 closed 6 years ago

andre77 commented 6 years ago

fixed name resolution of address book entries. the name resolution did not work 100% correct, if there are some white spaces in between the number, i.e. like this '+49 40 123 456 789'

9037568 commented 6 years ago

Why? I don't see any defects stating that name resolution doesn't work. Have you had any community testing for this change?

andre77 commented 6 years ago

@9037568 just put some white spaces into a tel number inside your address book on the fritz box ( like this '+49 40 123 456 789') and make a call from this number. the current version will not find a match because of the white spaces

9037568 commented 6 years ago

Then don't put the whitespaces in. I don't use or even have a fritzbox.

andre77 commented 6 years ago

@9037568 its not forbidden to put white spaces into the tel numbers. it makes them even more readable. so why not? most of the phones like for example iphone even add a white space automatically to separate the prefix of the tel number. but why are you worried about the changes for a fritz box binding, if you even don't have one? :-) or are u using the binding with another device, which supports the TR064 protocol?

9037568 commented 6 years ago

Thanks, @kaikreuzer, for the confirmation. Thanks for the patch, @andre77 !

openhab-bot commented 6 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/fritzbox-tr064-binding-problem-resolving-external-call-number-to-name-with-a-google-synced-phonebook/39609/5