search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.7k forks source link

[CUL] Request credit info when opening device #5686

Closed hadogenes closed 3 years ago

hadogenes commented 5 years ago

After #5329 the credit10ms is 0 and it cannot send anything, because the credit status will be never updated

openhab-bot commented 5 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh2-cul/31193/11

johgoe commented 5 years ago

looks like a revert of #5329 but because the change in #5329 in method requestCreditReport() which queues the command instead of synchronuous writing, makes the differnce.

@9037568 Can you care about this issue as you was the merger of #5329?

9037568 commented 5 years ago

I don't have a deep enough knowledge of CUL and this binding to be able to resolve these changes against the earlier ones in #5329.

I suggest hashing it out in the forum in either a new thread or the original.

openhab-bot commented 5 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh2-cul/31193/15

openhab-bot commented 5 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/cul-transport-fix-for-issue-with-cul-transport-race-condition/35385/21

MooLMihaly commented 5 years ago

Are there any new on the pull request? All CUL users are affected.

MooLMihaly commented 5 years ago

Are there any news on the pull request? All CUL users are affected.

MichaelKlemm commented 5 years ago

Looks fine to me. Why the PRs taking that long?

MooLMihaly commented 5 years ago

A new month without progress again. Can we somehow support the request to be accepted finally? All CUL users are affected.

MichaelKlemm commented 5 years ago

A new month without progress again. Can we somehow support the request to be accepted finally? All CUL users are affected.

Have you seen my comment? I think that PR could be improved. Nevertheless you‘re right, the support could be better. Maybe it’s because of legacy stuff.