search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

[Weather] Add support for APIXU and Weatherbit as weather provider #5750

Closed jmahmens closed 5 years ago

jmahmens commented 5 years ago

I 've added two new free provider for weather forecast.

Both provides a free forecast. Only ApiKey must be created like all other provider. I will try to create openhab2-addons for these both in the next day's.

9037568 commented 5 years ago

First, @jmahmens, thank you for your contribution. However, I'm not sure it makes sense to add new functionality to the OH1 platform, especially when you plan to create new matching OH2 addons.

@kaikreuzer what do you think?

jmahmens commented 5 years ago

First, @jmahmens, thank you for your contribution. However, I'm not sure it makes sense to add new functionality to the OH1 platform, especially when you plan to create new matching OH2 addons.

@kaikreuzer what do you think?

Well, i think this is a good startingpoint for development of new oh2 addons. I do this additon of new providers because yahoo was dropped and Wunderground dosn't support free use anymore. OpenWeatherMap provides no free 'daily' forecast, only 3hourly. DarkSky (forecastio), WorldWeaterOnline provides only a limited free forecast. So this both APIXU and Weatherbit are a chance for those OH1 user have only change their provider and not the whole System.

jmahmens commented 5 years ago

Sorry closed accidently

kaikreuzer commented 5 years ago

@kaikreuzer what do you think?

As @jmahmens did the work, I think it is fair to merge it. But in general, I very much agree that new features should rather be done directly as OH2 bindings.

jmahmens commented 5 years ago

I've tryed to resolve the review findings. Please do a new rewiev.

9037568 commented 5 years ago

Thanks, @jmahmens !

jmahmens commented 5 years ago

Thanks for mergin this. I will now try the next step. But one question. Should I try develop an OH2 binding or an eclipse. A good template for these two new provider are die existing Wunderground and openweathermap eclipse bindings.

kaikreuzer commented 5 years ago

@jmahmens Please go for adding them to the openhab2-addons repo - thanks!