search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

[InsteonPLM] Added OnLevel feature to Insteon PLM 2477D dimmer #5775

Closed crxporter closed 5 years ago

crxporter commented 5 years ago

This will add the ability to add on level items into OpenHAB for the Insteon PLM binding. Items should be number type with a range from 0 to 255. The feature works the same as other features in the binding (LEDBrightness and RampRate).

RampRate is Insteon message 0x05. LEDBrightness is Insteon message 0x07. OnLevel (new) is Insteon message 0x06.

openhab-bot commented 5 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/improving-support-for-2441v-insteon-thermostat-adaptor-for-venstar/64504/8

openhab-bot commented 5 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/insteon-my-own-feature-new-i-think-onlevel/52141/1

9037568 commented 5 years ago

LGTM, but let's see if @berndpfrommer has any comments.

berndpfrommer commented 5 years ago

@crxporter Thanks for the contribution! Apologies I cannot test it since I no longer have a working OH dev environment. The change looks good to me. The only comment I have is that this feature is probably supported by more than just the 2477D. Support for the other devices can be added later, so from my perspective this is good to go.

9037568 commented 5 years ago

Thanks, @crxporter !