openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

Legacy bindings missing from feature.xml don't show obsolete message on documentation page #5781

Closed Hilbrand closed 3 years ago

Hilbrand commented 5 years ago

Not all bindings show the obsolete warning on the documentation pages, see https://www.openhab.org/addons/bindings/maxcube1/. As a user reported in https://github.com/openhab/openhab2-addons/issues/4807. Unlike this binding: https://www.openhab.org/addons/bindings/dsmr1

I suspect this is caused because these bindings are not present in a feature.xml For example the mcp23017 and maxcube1 are missing, while the mentioned binding dsmr1 is part of the legacy feature. This also means they won't be listed in PaperUI (even with legacy bindings enabled, and might even not possible to install if they depend on other specific features). Only if the user would manually add the binding it's possible to install (probably the most likely way this binding is installed though, if still used, because that was the way to do it in openHAB1).

So I think it might be a good idea to see if this also applies to more bindings and than take action: Either remove the binding completely here or add the binding to the legacy feature.xml (assuming that will trigger the deprecation warning on the openHAB documentation page)