search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

[Tinkerforge] support for new Bricklets #5816

Closed andiikaa closed 4 years ago

andiikaa commented 5 years ago

As promised in #5785, some new bindings are supported.

This PR:

I will later add the support for the following bricklets:

Note: It seems that the tinkerforge xcore model wasn't touched for while. My changes seems to trigger the auto format for all model files.

Signed-off-by: André Kühnert andre.kuehnie@gmail.com (github: andiikaa)

andiikaa commented 5 years ago

I added the missing OLED 128x64 Bricklet 2.0 and LCD 128x64 Bricklet. I noticed, that the OLED 64x48 Bricklet and OLED 128x64 Bricklet 1.0 are also implemented but are missing in the readme, so i added a (really) short description.

This will close #5785.

Signed-off-by: André Kühnert andre.kuehnie@gmail.com (github: andiikaa)

theoweiss commented 5 years ago

Just had a very quick look add the diffs. Looks promising. I'm really short of time in these days, may be some one else could review the requirements which are not tinkerforge specific @watou @9037568 and I will do the remaining review? Among others I'm working on an openhab2 tinkerforge binding.

theoweiss commented 5 years ago

Almost forgotten: @andiikaa thanks for the PR!

kaikreuzer commented 4 years ago

Sorry to see that this is hanging since forever without a review. @andiikaa & @theoweiss Do you still want to pursue this or is it meanwhile outdated as there are better options to use Tinkerforge in openHAB 2 by now?

andiikaa commented 4 years ago

For me it is not that important that it gets merged. My project is done and i don´t have access to the bricklets anymore. I´ve just seen that there is now a Binding Generator directly from tinkerforge, but i did not compare which bricklets are supported for now.

With the generator it should also be easy to add new bricklets. So in my opinion this OH1 binding gets outdated really fast. So no one should invest much time in it.

theoweiss commented 4 years ago

A beta of the new OH2 binding is available from here https://www.tinkerunity.org/topic/4901-betaversion-der-openhab-bindings/ (de) or here https://www.tinkerunity.org/topic/4909-beta-version-of-the-openhab-bindings/ (en). The binding is evolving fast and now supports most of the available bricklets. It works with openHAB 2.5.0~M*. Hopefully the TinkerForge people will make a PR to contribute the binding to the official openHAB stack: https://www.tinkerunity.org/topic/4901-betaversion-der-openhab-bindings/page/4/?tab=comments#comment-28099 (de). I think new TF users should use the new binding and current users should switch to the new binding as soon as they need support for a bricklet which is not supported with the OH1 binding. I agree with André and suggest to abandon the work on the OH1 TinkerForge binding and to close this PR.

kaikreuzer commented 4 years ago

Ok, many thanks for your opinions - so let's close this PR then.