[Misc.] Fix some alerts raised by LGTM

malcolmtaylor commented 5 years ago

LGTM raised some alerts during analysis of openhab1-addons: (https://lgtm.com/projects/g/openhab/openhab1-addons/alerts/?mode=list).

Fixed some of the alerts:

ArrayIndexOutOfBounds in HarmonyHubDiscovery
ContradictoryTypeChecks in various classes
Equals on incomparable types in OneWireDecimalTypeMultiplyModifier and UCPRelayBoardBinding
Hashed value without hashCode definition in XMLMessageReader
Inconsistent hashCode and equals in Field
Missing format argument in various classes
Reference equality of boxed types in ZWaveSceneConverter
Type mismatch on container access in Tr064Comm

malcolmtaylor commented 5 years ago

@9037568 thanks for reviewing. I have addressed your comments, but there a few places where different solutions are possible and I'm not sure which you'd prefer. Please let me know your preference.

malcolmtaylor commented 5 years ago

@9037568 thanks, I have restored the exception messages to their previous form, and also removed some unused imports.

9037568 commented 5 years ago

Thanks, @1m2c3t4 !

openhab / openhab1-addons

[Misc.] Fix some alerts raised by LGTM #5818